Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7145)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 989843002: [Extensions] Make chrome://extensions use developerPrivate for inspect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 16b11322a5281b1d57869ed58818efc5323d9662..f9c68fe72ef97a41a2af2b2307f0968239b517ba 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -731,12 +731,11 @@ cr.define('extensions', function() {
link.textContent = label;
link.clickHandler = function(e) {
// TODO(estade): remove conversion to string?
- chrome.send('extensionSettingsInspect', [
- String(extension.id),
- String(view.renderProcessId),
- String(view.renderViewId),
- view.incognito
- ]);
+ chrome.developerPrivate.inspect(
not at google - send to devlin 2015/03/09 18:26:38 I very much prefer a style like chrome.developerP
Devlin 2015/03/09 19:13:57 I tend to prefer it, too, but not sure how common
+ {extension_id: String(extension.id),
+ render_process_id: String(view.renderProcessId),
+ render_view_id: String(view.renderViewId),
+ incognito: view.incognito});
};
link.addEventListener('click', link.clickHandler);

Powered by Google App Engine
This is Rietveld 408576698