Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 <include src="extension_error.js"> | 5 <include src="extension_error.js"> |
| 6 | 6 |
| 7 /** | 7 /** |
| 8 * The type of the extension data object. The definition is based on | 8 * The type of the extension data object. The definition is based on |
| 9 * chrome/browser/ui/webui/extensions/extension_basic_info.cc | 9 * chrome/browser/ui/webui/extensions/extension_basic_info.cc |
| 10 * and | 10 * and |
| (...skipping 713 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 724 var displayName = view.generatedBackgroundPage ? | 724 var displayName = view.generatedBackgroundPage ? |
| 725 loadTimeData.getString('backgroundPage') : view.path; | 725 loadTimeData.getString('backgroundPage') : view.path; |
| 726 var label = displayName + | 726 var label = displayName + |
| 727 (view.incognito ? | 727 (view.incognito ? |
| 728 ' ' + loadTimeData.getString('viewIncognito') : '') + | 728 ' ' + loadTimeData.getString('viewIncognito') : '') + |
| 729 (view.renderProcessId == -1 ? | 729 (view.renderProcessId == -1 ? |
| 730 ' ' + loadTimeData.getString('viewInactive') : ''); | 730 ' ' + loadTimeData.getString('viewInactive') : ''); |
| 731 link.textContent = label; | 731 link.textContent = label; |
| 732 link.clickHandler = function(e) { | 732 link.clickHandler = function(e) { |
| 733 // TODO(estade): remove conversion to string? | 733 // TODO(estade): remove conversion to string? |
| 734 chrome.send('extensionSettingsInspect', [ | 734 chrome.developerPrivate.inspect( |
|
not at google - send to devlin
2015/03/09 18:26:38
I very much prefer a style like
chrome.developerP
Devlin
2015/03/09 19:13:57
I tend to prefer it, too, but not sure how common
| |
| 735 String(extension.id), | 735 {extension_id: String(extension.id), |
| 736 String(view.renderProcessId), | 736 render_process_id: String(view.renderProcessId), |
| 737 String(view.renderViewId), | 737 render_view_id: String(view.renderViewId), |
| 738 view.incognito | 738 incognito: view.incognito}); |
| 739 ]); | |
| 740 }; | 739 }; |
| 741 link.addEventListener('click', link.clickHandler); | 740 link.addEventListener('click', link.clickHandler); |
| 742 | 741 |
| 743 if (i < extension.views.length - 1) { | 742 if (i < extension.views.length - 1) { |
| 744 link = link.cloneNode(true); | 743 link = link.cloneNode(true); |
| 745 item.appendChild(link); | 744 item.appendChild(link); |
| 746 } | 745 } |
| 747 }); | 746 }); |
| 748 | 747 |
| 749 var allLinks = item.querySelectorAll('a'); | 748 var allLinks = item.querySelectorAll('a'); |
| (...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 907 // TODO(dbeam): why do we need to focus <extensionoptions> before and | 906 // TODO(dbeam): why do we need to focus <extensionoptions> before and |
| 908 // after its showing animation? Makes very little sense to me. | 907 // after its showing animation? Makes very little sense to me. |
| 909 overlay.setInitialFocus(); | 908 overlay.setInitialFocus(); |
| 910 }, | 909 }, |
| 911 }; | 910 }; |
| 912 | 911 |
| 913 return { | 912 return { |
| 914 ExtensionList: ExtensionList | 913 ExtensionList: ExtensionList |
| 915 }; | 914 }; |
| 916 }); | 915 }); |
| OLD | NEW |