Chromium Code Reviews| Index: chrome/browser/extensions/api/developer_private/developer_private_api.h |
| diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.h b/chrome/browser/extensions/api/developer_private/developer_private_api.h |
| index 60edc0ce3ed328e7cf14d5221df7ff957d5c319c..07f464aeb8b31474f47ed6cc72a63e16b4898350 100644 |
| --- a/chrome/browser/extensions/api/developer_private/developer_private_api.h |
| +++ b/chrome/browser/extensions/api/developer_private/developer_private_api.h |
| @@ -188,44 +188,44 @@ class DeveloperPrivateAutoUpdateFunction : public ChromeSyncExtensionFunction { |
| }; |
| class DeveloperPrivateGetItemsInfoFunction |
| - : public ChromeAsyncExtensionFunction { |
| + : public DeveloperPrivateAPIFunction { |
| public: |
| DECLARE_EXTENSION_FUNCTION("developerPrivate.getItemsInfo", |
| DEVELOPERPRIVATE_GETITEMSINFO) |
| + DeveloperPrivateGetItemsInfoFunction(); |
| - protected: |
| + private: |
| ~DeveloperPrivateGetItemsInfoFunction() override; |
| + ResponseAction Run() override; |
| - // ExtensionFunction: |
| - bool RunAsync() override; |
| + void GetIconsOnFileThread( |
| + std::map<std::string, ExtensionResource> resource_map); |
| + void Finish(); |
| + |
| + ItemInfoList item_list_; |
| +}; |
| + |
| +class DeveloperPrivateGetExtensionsInfoFunction |
| + : public DeveloperPrivateAPIFunction { |
| + public: |
| + DECLARE_EXTENSION_FUNCTION("developerPrivate.getExtensionsInfo", |
| + DEVELOPERPRIVATE_GETEXTENSIONSINFO); |
| private: |
| - scoped_ptr<developer::ItemInfo> CreateItemInfo(const Extension& item, |
| - bool item_is_enabled); |
| + ~DeveloperPrivateGetExtensionsInfoFunction() override; |
| - void GetIconsOnFileThread( |
| - ItemInfoList item_list, |
| - std::map<std::string, ExtensionResource> itemIdToIconResourceMap); |
| - |
| - // Helper that lists the current inspectable html pages for the extension. |
| - void GetInspectablePagesForExtensionProcess( |
| - const Extension* extension, |
| - const std::set<content::RenderViewHost*>& views, |
| - ItemInspectViewList* result); |
| - |
| - ItemInspectViewList GetInspectablePagesForExtension( |
| - const Extension* extension, |
| - bool extension_is_enabled); |
| - |
| - void GetAppWindowPagesForExtensionProfile(const Extension* extension, |
| - ItemInspectViewList* result); |
| - |
| - linked_ptr<developer::ItemInspectView> constructInspectView( |
| - const GURL& url, |
| - int render_process_id, |
| - int render_view_id, |
| - bool incognito, |
| - bool generated_background_page); |
| + ResponseAction Run() override; |
| +}; |
|
not at google - send to devlin
2015/03/11 17:43:05
Was this lack of a blank line intentional?
Devlin
2015/03/11 21:45:53
Nope.
|
| +class DeveloperPrivateGetExtensionInfoFunction |
| + : public DeveloperPrivateAPIFunction { |
| + public: |
| + DECLARE_EXTENSION_FUNCTION("developerPrivate.getExtensionInfo", |
| + DEVELOPERPRIVATE_GETEXTENSIONINFO); |
| + |
| + private: |
| + ~DeveloperPrivateGetExtensionInfoFunction() override; |
| + |
| + ResponseAction Run() override; |
| }; |
| class DeveloperPrivateInspectFunction : public ChromeSyncExtensionFunction { |