[Extensions] Make a chrome.developerPrivate.getExtensionsInfo function

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 /**
  * The type of the extension data object. The definition is based on
  * chrome/browser/ui/webui/extensions/extension_basic_info.cc
  * and
@@ skipping 40 matching lines @@
  *            policyText: (string|undefined),
  *            prettifiedPath: (string|undefined),
  *            recommendedInstall: boolean,
  *            runtimeErrors: (Array<RuntimeError>|undefined),
  *            showAllUrls: boolean,
  *            suspiciousInstall: boolean,
  *            terminated: boolean,
  *            updateRequiredByPolicy: boolean,
  *            version: string,
  *            views: Array<{renderViewId: number, renderProcessId: number,
- *                path: string, incognito: boolean,
- *                generatedBackgroundPage: boolean}>,
+ *                url: string, incognito: boolean,
+ *                type: chrome.developerPrivate.ViewType}>,
  *            wantsErrorCollection: boolean,
  *            wantsFileAccess: boolean,
  *            warnings: (Array|undefined)}}
  */
 var ExtensionData;
 
 ///////////////////////////////////////////////////////////////////////////////
 // ExtensionFocusRow:
 
 /**
@@ skipping 648 matching lines @@
 
         // Link needs to be an only child before the list is updated.
         while (link.nextElementSibling)
           item.removeChild(link.nextElementSibling);
 
         // Link needs to be cleaned up if it was used before.
         link.textContent = '';
         if (link.clickHandler)
           link.removeEventListener('click', link.clickHandler);
 
         extension.views.forEach(function(view, i) {

[Dan Beam, 2015/03/12 00:23:15]

nit: if it fits, i think this is purdier

  var ViewType = chrome.developerPrivate.ViewType;
  extension.views.forEach(function(view, i)
    if (view.type == ViewType.EXTENSION_DIALOG || ViewType.EXTENSION_POPUP)
      return;

[Devlin, 2015/03/12 15:38:14]

But you're missing the second view.type == - should be
if (view.type == ViewType.EXTENSION_DIALOG ||
    view.type == ViewType.EXTENSION_POPUP)
which then doesn't save any lines.  Do you still have a preference for caching
it?

[Dan Beam, 2015/03/12 16:41:17]

oh, doh.  if it doesn't save lines don't bother, but add curlies

[Devlin, 2015/03/12 19:53:35]

Done.

-          var displayName = view.generatedBackgroundPage ?
-              loadTimeData.getString('backgroundPage') : view.path;
+          if (view.type == chrome.developerPrivate.ViewType.EXTENSION_DIALOG ||
+              view.type == chrome.developerPrivate.ViewType.EXTENSION_POPUP)
+            return;
+          var displayName;
+          if (view.url.indexOf('chrome-extension://') == 0) {
+            var pathOffset = 'chrome-extension://'.length + 32 + 1;
+            displayName = view.url.substring(pathOffset);
+            if (displayName == '_generated_background_page.html')
+              displayName = loadTimeData.getString('backgroundPage');
+          } else {
+            displayName = view.url;
+          }
           var label = displayName +
               (view.incognito ?
                   ' ' + loadTimeData.getString('viewIncognito') : '') +
               (view.renderProcessId == -1 ?
                   ' ' + loadTimeData.getString('viewInactive') : '');
           link.textContent = label;
           link.clickHandler = function(e) {
             chrome.developerPrivate.inspect({
               extension_id: extension.id,
               render_process_id: view.renderProcessId,
@@ skipping 170 matching lines @@
       // TODO(dbeam): why do we need to focus <extensionoptions> before and
       // after its showing animation? Makes very little sense to me.
       overlay.setInitialFocus();
     },
   };
 
   return {
     ExtensionList: ExtensionList
   };
 });