Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 989803002: Use base::PowerObserver to check for missed heartbeats (Closed)

Created:
5 years, 9 months ago by Chirantan Ekbote
Modified:
5 years, 9 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::PowerObserver to check for missed heartbeats base::PowerObserver provides a platform-agnostic way to be notified about system suspend and resume events. Use it to check for missed heartbeats instead of polling. Unfortunately we still need to poll on linux because there is no common system-wide notification about suspend and resume events. BUG=421725 Committed: https://crrev.com/7f8789c70bb9049c9357f512e92f8b44c061e892 Cr-Commit-Position: refs/heads/master@{#319730}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M google_apis/gcm/engine/heartbeat_manager.h View 3 chunks +6 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/heartbeat_manager.cc View 6 chunks +30 lines, -6 lines 2 comments Download
M google_apis/gcm/engine/heartbeat_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Chirantan Ekbote
Hi Nicolas, please take a look.
5 years, 9 months ago (2015-03-07 02:16:23 UTC) #2
Nicolas Zea
LGTM with a question. Have we had this power monitor all along? https://codereview.chromium.org/989803002/diff/1/google_apis/gcm/engine/heartbeat_manager.cc File google_apis/gcm/engine/heartbeat_manager.cc ...
5 years, 9 months ago (2015-03-09 18:42:52 UTC) #3
Chirantan Ekbote
On 2015/03/09 18:42:52, Nicolas Zea wrote: > LGTM with a question. Have we had this ...
5 years, 9 months ago (2015-03-09 19:23:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989803002/1
5 years, 9 months ago (2015-03-09 19:25:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 20:49:04 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 20:50:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f8789c70bb9049c9357f512e92f8b44c061e892
Cr-Commit-Position: refs/heads/master@{#319730}

Powered by Google App Engine
This is Rietveld 408576698