Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 989773002: Add a slimming paint variant of the typical 25 page cycler benchmark (Closed)

Created:
5 years, 9 months ago by pdr.
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a slimming paint variant of the typical 25 page cycler benchmark This patch adds a version of the typical 25 page cycler benchmark with the --enable-slimming-paint flag. I verified this works locally. BUG=464910

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove custom name #

Patch Set 3 : Re-add name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
pdr.
5 years, 9 months ago (2015-03-06 23:47:17 UTC) #2
pdr.
5 years, 9 months ago (2015-03-09 21:41:43 UTC) #3
chrishtr
lgtm
5 years, 9 months ago (2015-03-09 21:48:54 UTC) #4
sullivan
Please run on one perf trybot on each platform before submitting: http://www.chromium.org/developers/performance-try-bots https://codereview.chromium.org/989773002/diff/1/tools/perf/benchmarks/page_cycler.py File tools/perf/benchmarks/page_cycler.py ...
5 years, 9 months ago (2015-03-09 21:57:21 UTC) #6
sullivan
lgtm
5 years, 9 months ago (2015-03-09 21:57:27 UTC) #7
pdr.
trybot runs: nexus7 - https://codereview.chromium.org/992113002 linux - https://codereview.chromium.org/994783003 win8 - https://codereview.chromium.org/995593002 mac - https://codereview.chromium.org/995453004 I ...
5 years, 9 months ago (2015-03-09 23:07:19 UTC) #8
pdr.
On 2015/03/09 at 23:07:19, pdr wrote: > trybot runs: > nexus7 - https://codereview.chromium.org/992113002 > linux ...
5 years, 9 months ago (2015-03-10 18:42:41 UTC) #9
pdr.
On 2015/03/10 at 18:42:41, pdr wrote: > On 2015/03/09 at 23:07:19, pdr wrote: > > ...
5 years, 9 months ago (2015-03-11 20:12:54 UTC) #10
pdr.
On 2015/03/11 at 20:12:54, pdr wrote: > On 2015/03/10 at 18:42:41, pdr wrote: > > ...
5 years, 9 months ago (2015-03-16 17:53:39 UTC) #11
pdr.
5 years, 9 months ago (2015-03-16 20:39:18 UTC) #12
On 2015/03/16 at 17:53:39, pdr wrote:
> On 2015/03/11 at 20:12:54, pdr wrote:
> > On 2015/03/10 at 18:42:41, pdr wrote:
> > > On 2015/03/09 at 23:07:19, pdr wrote:
> > > > trybot runs:
> > > > nexus7 - https://codereview.chromium.org/992113002
> > > > linux - https://codereview.chromium.org/994783003
> > > > win8 - https://codereview.chromium.org/995593002
> > > > mac - https://codereview.chromium.org/995453004
> > > > 
> > > > I was unable to get this to work without the "def Name" override though
:(
> > > 
> > > All of these passed except linux and mac. Lets try them again:
> > > 
> > > linux - https://codereview.chromium.org/994163002
> > > mac - https://codereview.chromium.org/991393003
> > 
> > Hmm, linux and mac were sad last time. Lets try again with some more crash
fixes:
> > 
> > mac - https://codereview.chromium.org/999183002
> > linux - https://codereview.chromium.org/1004473002
> 
> Landed a crash fix last Friday, lets try again:
> linux - https://codereview.chromium.org/1010863002
> mac - https://codereview.chromium.org/1009403003
> mac10.9 - https://codereview.chromium.org/1011703004

Slight change in plan--if we can only run one benchmark, rasterize and record is
the one. Please follow https://codereview.chromium.org/1016503002, this review
should be closed.

Powered by Google App Engine
This is Rietveld 408576698