Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 989743004: Fix runtime assert in %LiveEditCheckAndDropActivations. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix runtime assert in %LiveEditCheckAndDropActivations. R=jarin@chromium.org BUG=chromium:465663 LOG=n Committed: https://crrev.com/8fb6660e76d59a92d61b3cf612d17910f4fd513d Cr-Commit-Position: refs/heads/master@{#27089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/runtime/runtime-liveedit.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
Seriously, the loop that contains runtime asserts that was put in to make fuzzing happy, ...
5 years, 9 months ago (2015-03-10 09:28:45 UTC) #1
Jarin
lgtm
5 years, 9 months ago (2015-03-10 09:31:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989743004/1
5 years, 9 months ago (2015-03-10 09:34:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 09:48:11 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 09:48:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fb6660e76d59a92d61b3cf612d17910f4fd513d
Cr-Commit-Position: refs/heads/master@{#27089}

Powered by Google App Engine
This is Rietveld 408576698