Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 989743003: Change the null value for packet sequence numbers to (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the null value for packet sequence numbers to kInvalidPacketSequenceNumber (== 0), which cannot appear as a packet sequence number. Update QuicFecGroupTest::UpdateAndRevive and QuicFecGroupTest::UpdateAndReviveOutOfOrder to generate packet numbers starting with 1 rather than 0. Change the null value for packet sequence numbers to kNullPacketSequenceNumber (== 0). Merge internal change: 87819844 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -72 lines) Patch
M net/quic/quic_fec_group.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_fec_group.cc View 9 chunks +18 lines, -19 lines 0 comments Download
M net/quic/quic_fec_group_test.cc View 11 chunks +59 lines, -49 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-07 01:36:01 UTC) #1
Ryan Hamilton
5 years, 9 months ago (2015-03-07 03:17:49 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698