Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 98973004: Fix invalid combobox painting issue in requestAutocomplete() dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/combobox/combobox.cc
diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc
index 2600b174f07d27d2e9f3f8511ca71049270a444c..2a4f04d536dbaec2fbd005d7bebc79eccd8a54bc 100644
--- a/ui/views/controls/combobox/combobox.cc
+++ b/ui/views/controls/combobox/combobox.cc
@@ -140,14 +140,18 @@ void Combobox::SetAccessibleName(const string16& name) {
}
void Combobox::SetInvalid(bool invalid) {
+ if (invalid == invalid_)
+ return;
+
invalid_ = invalid;
- if (invalid) {
+ if (invalid_) {
text_border_->SetColor(kWarningColor);
set_background(new InvalidBackground());
} else {
text_border_->UseDefaultColor();
set_background(NULL);
}
+ SchedulePaint();
}
ui::TextInputClient* Combobox::GetTextInputClient() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698