Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: snapshot/mac/process_reader.h

Issue 989713002: snapshot/mac: MachOImageAnnotationsReader test shouldn’t crash with a nullptr ProcessReader::Module (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/mac/mach_o_image_annotations_reader_test.cc ('k') | snapshot/mac/process_reader_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/mac/process_reader.h
diff --git a/snapshot/mac/process_reader.h b/snapshot/mac/process_reader.h
index 0227adecd4b998d2a4f518614330dd7fd6361fec..a781667f2829d0042d22bf6ad91f665bbef1dc43 100644
--- a/snapshot/mac/process_reader.h
+++ b/snapshot/mac/process_reader.h
@@ -84,6 +84,9 @@ class ProcessReader {
//!
//! The lifetime of this MachOImageReader is scoped to the lifetime of the
//! ProcessReader that created it.
+ //!
+ //! This field may be `nullptr` if a reader could not be created for the
+ //! module.
const MachOImageReader* reader;
//! \brief The module’s timestamp.
« no previous file with comments | « snapshot/mac/mach_o_image_annotations_reader_test.cc ('k') | snapshot/mac/process_reader_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698