Add support for backgrounding processes on the Mac

content/browser/child_process_launcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/child_process_launcher.h"
 
 #include <utility>  // For std::pair.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_file.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/process/process.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/common/content_descriptors.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/result_codes.h"
 #include "content/public/common/sandboxed_process_launcher_delegate.h"
@@ skipping 471 matching lines @@
 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_ANDROID)
                 zygote_,
 #endif
                 base::Passed(&process_)));
 }
 
 // static
 void ChildProcessLauncher::Context::SetProcessBackgroundedInternal(
     base::Process process,
     bool background) {
+#if defined(OS_MACOSX)
+  base::FieldTrial* trial =
+      base::FieldTrialList::Find("BackgroundMacRendererProcesses");

[Alexei Svitkine (slow), 2015/03/11 15:30:54]

Nit: You can just use FindFullName() and then the logic below becomes simpler.
(It will return "" if no trial).

[shrike, 2015/03/11 21:38:21]

Done.

+  if (trial && trial->group_name() == "On") {

[gab, 2015/03/10 12:33:02]

I would suggest taking this path by default in the absence of field trials,
i.e.:
if (!trial || trial->group_name() == "On") {...

This will make this the default behavior on bots (in particular perf bots).

The only downside is that you'll have to make sure to have a Finch config
initially explicitly disabling it on Beta/Stable.

[shrike, 2015/03/10 18:00:33]

OK. Will Finch flags be available soon enough after startup so that they'll
exist before any render processes get backgrounded?

[gab, 2015/03/10 19:43:50]

Yes, Finch is brought up before creating any threads/processes if I'm no
mistaken.

@asvitkine to confirm

[Alexei Svitkine (slow), 2015/03/11 15:30:54]

Correct.

+    MachBroker* broker = MachBroker::GetInstance();
+    process.SetProcessBackgrounded(broker->TaskForPid(process.Pid()),
+                                   background);
+  }
+#else
   process.SetProcessBackgrounded(background);
+#endif  // defined(OS_MACOSX)
 #if defined(OS_ANDROID)
   SetChildProcessInForeground(process.Handle(), !background);
 #endif
 }
 
 // static
 void ChildProcessLauncher::Context::TerminateInternal(
 #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_ANDROID)
     bool zygote,
 #endif
@@ skipping 78 matching lines @@
   context_->SetProcessBackgrounded(background);
 }
 
 void ChildProcessLauncher::SetTerminateChildOnShutdown(
     bool terminate_on_shutdown) {
   if (context_.get())
     context_->set_terminate_child_on_shutdown(terminate_on_shutdown);
 }
 
 }  // namespace content