Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2226)

Issue 989683002: Fix bit rot in SkGlyphCache validate code. (Closed)

Created:
5 years, 9 months ago by herb_g
Modified:
5 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix bit rot in SkGlyphCache validate code. TESTED CFLAGS=-DSK_DEBUG_GLYPH_CACHE CPPFLAGS=-DSK_DEBUG_GLYPH_CACHE ./gyp_skia ninja -C out/Debug dm out/Debug/dm Committed: https://skia.googlesource.com/skia/+/c2ff52920b43304e83d7def592dfacc73b54373e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/core/SkGlyphCache.cpp View 1 chunk +1 line, -5 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989683002/1
5 years, 9 months ago (2015-03-06 22:10:02 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-06 22:10:03 UTC) #4
mtklein
lgtm https://codereview.chromium.org/989683002/diff/1/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/989683002/diff/1/src/core/SkGlyphCache.cpp#newcode665 src/core/SkGlyphCache.cpp:665: const SkGlyph* glyph = &fGlyphArray[i]; Might want to ...
5 years, 9 months ago (2015-03-06 22:25:28 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 00:15:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c2ff52920b43304e83d7def592dfacc73b54373e

Powered by Google App Engine
This is Rietveld 408576698