Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issue 989673002: Fix the disabled attribute in cr-dropdown-menu: s/reflected/reflect. (Closed)

Created:
5 years, 9 months ago by Jeremy Klein
Modified:
5 years, 9 months ago
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org, oshima+watch_chromium.org, dcheng, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the disabled attribute in cr-dropdown-menu: s/reflected/reflect. BUG= Committed: https://crrev.com/447304b256f3ee4fdea7fd019fb46ab29ad82d58 Cr-Commit-Position: refs/heads/master@{#319710}

Patch Set 1 #

Total comments: 1

Patch Set 2 : disabled opacity -> 0.33 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.css View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_dropdown_menu/demo.html View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Jeremy Klein
*facepalm*.... This time I checked the enabled version too :-).
5 years, 9 months ago (2015-03-06 22:05:27 UTC) #2
Oren Blasberg
lgtm
5 years, 9 months ago (2015-03-06 22:11:19 UTC) #3
michaelpg
lgtm https://codereview.chromium.org/989673002/diff/1/ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.css File ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.css (right): https://codereview.chromium.org/989673002/diff/1/ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.css#newcode10 ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.css:10: opacity: .5; Just wondering where the opacity value ...
5 years, 9 months ago (2015-03-06 22:36:54 UTC) #4
Jeremy Klein
On 2015/03/06 22:36:54, michaelpg wrote: > lgtm > > https://codereview.chromium.org/989673002/diff/1/ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.css > File ui/webui/resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.css > (right): ...
5 years, 9 months ago (2015-03-06 22:42:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989673002/20001
5 years, 9 months ago (2015-03-06 22:43:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 00:45:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989673002/20001
5 years, 9 months ago (2015-03-09 17:55:51 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 19:25:24 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 19:26:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/447304b256f3ee4fdea7fd019fb46ab29ad82d58
Cr-Commit-Position: refs/heads/master@{#319710}

Powered by Google App Engine
This is Rietveld 408576698