'make quickcheck': don't overwrite debug output.

'make quickcheck': don't overwrite debug output.

Achieved by turning optdebug into a first-class compilation mode.

R=bmeurer@chromium.org, machenbach@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=18236

[Jakob Kummerow, 2013-12-02 12:27:27]

Michael: Please review.

Benedikt, Toon: FYI. May it increase your productivity!

[Michael Achenbach, 2013-12-02 12:52:40]

https://codereview.chromium.org/98963002/diff/1/Makefile
File Makefile (right):

https://codereview.chromium.org/98963002/diff/1/Makefile#newcode363
Makefile:363: --arch-and-mode=$(FASTTESTMODES) $(TESTFLAGS)
Like that, flaky tests are not skipped anymore when testing release builds. I
think skipping them here is important, not only for speed but also for
reliability. How about a --quickcheck flag for the test driver instead?

https://codereview.chromium.org/98963002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/98963002/diff/1/tools/run-tests.py#newcode349
tools/run-tests.py:349: 
This overwrites the global options dependent on the execution order. The
execution order can be specified by arch_and_mode. So, whether or not an
optdebug build comes first influences the test behavior afterwards.

[Benedikt Meurer, 2013-12-02 14:15:13]

Not having looked into the nasty details... but I really love this CL!

[Jakob Kummerow, 2013-12-02 14:22:55]

Good points; PTAL.

https://codereview.chromium.org/98963002/diff/1/Makefile
File Makefile (right):

https://codereview.chromium.org/98963002/diff/1/Makefile#newcode363
Makefile:363: --arch-and-mode=$(FASTTESTMODES) $(TESTFLAGS)
On 2013/12/02 12:52:41, machenbach wrote:
> Like that, flaky tests are not skipped anymore when testing release builds. I
> think skipping them here is important, not only for speed but also for
> reliability. How about a --quickcheck flag for the test driver instead?

Done.

https://codereview.chromium.org/98963002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/98963002/diff/1/tools/run-tests.py#newcode349
tools/run-tests.py:349: 
On 2013/12/02 12:52:41, machenbach wrote:
> This overwrites the global options dependent on the execution order. The
> execution order can be specified by arch_and_mode. So, whether or not an
> optdebug build comes first influences the test behavior afterwards.

Done.

[Michael Achenbach, 2013-12-02 16:08:00]

lgtm

[Benedikt Meurer, 2013-12-03 06:29:48]

LGTM

[Jakob Kummerow, 2013-12-03 14:24:47]

Committed patchset #2 manually as r18236 (presubmit successful).