Source/bindings/core/v8/WorkerScriptController.cpp - Issue 989573002: Cleanly handle excessively long JS source strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/WorkerScriptController.cpp

Issue 989573002: Cleanly handle excessively long JS source strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: syntax error => general error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/WorkerScriptController.cpp

diff --git a/Source/bindings/core/v8/WorkerScriptController.cpp b/Source/bindings/core/v8/WorkerScriptController.cpp

index 24e152f4ff6c18606a8196070d6db31f10e8fe67..9f729d43ffd6e526f4693443b181f4cd5f6cd39c 100644

--- a/Source/bindings/core/v8/WorkerScriptController.cpp

+++ b/Source/bindings/core/v8/WorkerScriptController.cpp

@@ -183,8 +183,7 @@ ScriptValue WorkerScriptController::evaluate(const String& script, const String&

v8::TryCatch block;

- v8::Handle<v8::String> scriptString = v8String(isolate(), script);

- v8::Handle<v8::Script> compiledScript = V8ScriptRunner::compileScript(scriptString, fileName, String(), scriptStartPosition, isolate(), nullptr, nullptr, cacheHandler, SharableCrossOrigin, v8CacheOptions);

+ v8::Handle<v8::Script> compiledScript = V8ScriptRunner::compileScript(script, fileName, String(), scriptStartPosition, isolate(), cacheHandler, SharableCrossOrigin, v8CacheOptions);

v8::Local<v8::Value> result = V8ScriptRunner::runCompiledScript(isolate(), compiledScript, &m_workerGlobalScope);

if (!block.CanContinue()) {

« no previous file with comments | « Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | no next file » | no next file with comments »