Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 989553002: Fix crash in ViewManager: fail gracefully when no ServiceProvider is (Closed)

Created:
5 years, 9 months ago by etiennej_google
Modified:
5 years, 9 months ago
Reviewers:
jamesr, sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org, jamesr
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix crash in ViewManager: fail gracefully when no ServiceProvider is sent when connecting to ViewManager. R=sky@chromium.org, jamesr@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/672d02b21ab19e56df8329f73612bdcb259633c7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M services/view_manager/view_manager_app.cc View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
etiennej_google
5 years, 9 months ago (2015-03-06 12:18:46 UTC) #1
jamesr
r->sky to see if this makes sense don't put "BUG=" in the patch description if ...
5 years, 9 months ago (2015-03-06 17:15:02 UTC) #3
sky
https://codereview.chromium.org/989553002/diff/1/services/view_manager/view_manager_app.cc File services/view_manager/view_manager_app.cc (right): https://codereview.chromium.org/989553002/diff/1/services/view_manager/view_manager_app.cc#newcode48 services/view_manager/view_manager_app.cc:48: // If no ServiceProvider has been sent, refuse the ...
5 years, 9 months ago (2015-03-06 18:25:28 UTC) #4
sky
Sorry, yes, I agree. LGTM
5 years, 9 months ago (2015-03-06 20:18:50 UTC) #5
etiennej_google
5 years, 9 months ago (2015-03-09 09:59:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
672d02b21ab19e56df8329f73612bdcb259633c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698