chrome/browser/android/chrome_jni_registrar.cc - Issue 989523003: Add metrics for tracking how Chrome handled shortcut launches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_jni_registrar.cc

Issue 989523003: Add metrics for tracking how Chrome handled shortcut launches (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappMetrics.java ('k') | chrome/browser/android/metrics/launch_metrics.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/chrome_jni_registrar.cc

diff --git a/chrome/browser/android/chrome_jni_registrar.cc b/chrome/browser/android/chrome_jni_registrar.cc

index a055a14dea879c291bad47558f710008f46543e6..b1edd1bc35560edcf510ae362db3532b6a1b3ce4 100644

--- a/chrome/browser/android/chrome_jni_registrar.cc

+++ b/chrome/browser/android/chrome_jni_registrar.cc

@@ -32,6 +32,7 @@

#include "chrome/browser/android/intent_helper.h"

#include "chrome/browser/android/location_settings_impl.h"

#include "chrome/browser/android/logo_bridge.h"

+#include "chrome/browser/android/metrics/launch_metrics.h"

#include "chrome/browser/android/metrics/uma_bridge.h"

#include "chrome/browser/android/metrics/uma_session_stats.h"

#include "chrome/browser/android/metrics/uma_utils.h"

@@ -55,7 +56,6 @@

#include "chrome/browser/android/tab_state.h"

#include "chrome/browser/android/url_utilities.h"

#include "chrome/browser/android/voice_search_tab_helper.h"

-#include "chrome/browser/android/webapps/webapp_metrics.h"

#include "chrome/browser/autofill/android/personal_data_manager_android.h"

#include "chrome/browser/dom_distiller/dom_distiller_service_factory_android.h"

#include "chrome/browser/dom_distiller/tab_utils_android.h"

@@ -192,6 +192,7 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {

{"IntentHelper", RegisterIntentHelper},

{"JavascriptAppModalDialog",

JavascriptAppModalDialogAndroid::RegisterJavascriptAppModalDialog},

+ {"LaunchMetrics", metrics::RegisterLaunchMetrics},

{"LayerTitleCache", chrome::android::RegisterLayerTitleCache},

{"LocationSettings", LocationSettingsImpl::Register},

{"LogoBridge", RegisterLogoBridge},

@@ -237,7 +238,6 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {

{"UmaSessionStats", RegisterUmaSessionStats},

{"UrlUtilities", RegisterUrlUtilities},

{"Variations", variations::android::RegisterVariations},

- {"WebappMetrics", webapps::WebappMetrics::Register},

{"WebsitePreferenceBridge", RegisterWebsitePreferenceBridge},

{"WebsiteSettingsPopupAndroid",

WebsiteSettingsPopupAndroid::RegisterWebsiteSettingsPopupAndroid},