Add metrics for tracking how Chrome handled shortcut launches

Add metrics for tracking how Chrome handled shortcut launches

* Generalizes WebappMetrics as LaunchMetrics to allow recording
  information about Home screen bookmark launches, which are
  handled as Tabs.

* Removes the previous count metric without marking it as
  obsolete because the downstream calling code never landed.

* Splits the previous RAPPOR metric into two to differentiate
  between shortcut and web app launches.  Again, calling code
  never landed.

BUG=462745
Committed: https://crrev.com/0e71dffca1885161e052d5c9fd3afed5c8aab5e1
Cr-Commit-Position: refs/heads/master@{#319551}

[gone, 2015-03-06 20:00:36]

dfalcantara@chromium.org changed reviewers:
+ holte@chromium.org, isherman@chromium.org, tedchoc@chromium.org

[gone, 2015-03-06 20:00:36]

Take two. Effectively expanded the previous CL to support another similar use
case.

[Ilya Sherman, 2015-03-06 21:08:11]

https://codereview.chromium.org/989523003/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/989523003/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:11201: +<histogram
name="HomeScreen.Launch" enum="HomeScreenLaunch">
It looks like you're creating a new "HomeScreen" group.  It's generally best to
try to keep the top-level namespace sparsely populated, and to group new
histograms into existing groups, where that makes sense.  Is there an existing
group that would make sense to use for this histogram?  (You might have already
thought about this, and decided that the answer is "no".  It just seems like
"HomeScreen" is hyper-specific, and not likely to garner any additional related
histograms.  I'm wondering if there's not a more general concept that this
metric falls under, which we'd expect to want to also measure.)

https://codereview.chromium.org/989523003/diff/20001/tools/metrics/rappor/rap...
File tools/metrics/rappor/rappor.xml (right):

https://codereview.chromium.org/989523003/diff/20001/tools/metrics/rappor/rap...
tools/metrics/rappor/rappor.xml:109: <rappor-metric
name="HomeScreen.LaunchURL.shortcut" type="ETLD_PLUS_ONE">
nit: Please be consistent with case conventions, i.e. capitalize "Shortcut".

https://codereview.chromium.org/989523003/diff/20001/tools/metrics/rappor/rap...
tools/metrics/rappor/rappor.xml:118: <rappor-metric
name="HomeScreen.LaunchURL.standalone" type="ETLD_PLUS_ONE">
(Ditto)

[Ted C, 2015-03-06 21:12:48]

https://codereview.chromium.org/989523003/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java
(right):

https://codereview.chromium.org/989523003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java:16:
public class LaunchMetrics {
Should this be HomescreenLaunchMetrics?

This name seems very generic and the recordStandaloneActivityLaunch seems like
it could apply to external intents coming from gmail for example.  I think we
need to clarify "somehow" that this is for tracking things the user has added to
the homescreen (whether it be a webapp shortcut or a bookmark link).

And with that said, do we track the add to homescreen as a bookmark differently
than we track if the user added a bookmark shortcut widget themselves?

[gone, 2015-03-06 22:14:09]

https://codereview.chromium.org/989523003/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java
(right):

https://codereview.chromium.org/989523003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java:16:
public class LaunchMetrics {
On 2015/03/06 21:12:48, Ted C wrote:
> Should this be HomescreenLaunchMetrics?
> 
> This name seems very generic and the recordStandaloneActivityLaunch seems like
> it could apply to external intents coming from gmail for example.  I think we
> need to clarify "somehow" that this is for tracking things the user has added
to
> the homescreen (whether it be a webapp shortcut or a bookmark link).
> 
> And with that said, do we track the add to homescreen as a bookmark
differently
> than we track if the user added a bookmark shortcut widget themselves?

I was kind of hoping to move that stuff from IntentHandler into here later,
actually
(IntentHandler.ExternalAppId, IntentHandler.determineExternalIntentSource,
IntentHandler.recordExternalIntentSourceUMA, etc).  It's not required for the
bug, yet,
though, and will make it harder to make a cherry-pick.

Clarified with Owen; we're lumping all home screen bookmarks all together.

https://codereview.chromium.org/989523003/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/989523003/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:11201: +<histogram
name="HomeScreen.Launch" enum="HomeScreenLaunch">
On 2015/03/06 21:08:11, Ilya Sherman wrote:
> It looks like you're creating a new "HomeScreen" group.  It's generally best
to
> try to keep the top-level namespace sparsely populated, and to group new
> histograms into existing groups, where that makes sense.  Is there an existing
> group that would make sense to use for this histogram?  (You might have
already
> thought about this, and decided that the answer is "no".  It just seems like
> "HomeScreen" is hyper-specific, and not likely to garner any additional
related
> histograms.  I'm wondering if there's not a more general concept that this
> metric falls under, which we'd expect to want to also measure.)

Trying to group it under the top-level "Launch", which only has a "Launch.Modes"
in it.

https://codereview.chromium.org/989523003/diff/20001/tools/metrics/rappor/rap...
File tools/metrics/rappor/rappor.xml (right):

https://codereview.chromium.org/989523003/diff/20001/tools/metrics/rappor/rap...
tools/metrics/rappor/rappor.xml:109: <rappor-metric
name="HomeScreen.LaunchURL.shortcut" type="ETLD_PLUS_ONE">
On 2015/03/06 21:08:11, Ilya Sherman wrote:
> nit: Please be consistent with case conventions, i.e. capitalize "Shortcut".

Done.

https://codereview.chromium.org/989523003/diff/20001/tools/metrics/rappor/rap...
tools/metrics/rappor/rappor.xml:118: <rappor-metric
name="HomeScreen.LaunchURL.standalone" type="ETLD_PLUS_ONE">
On 2015/03/06 21:08:11, Ilya Sherman wrote:
> (Ditto)

Done.

[Ilya Sherman, 2015-03-07 00:04:46]

metrics LGTM, thanks.

[Ted C, 2015-03-07 00:23:54]

lgtm - the method name clarifications work for me.

[gone, 2015-03-07 00:34:34]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-03-07 00:36:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/989523003/60001

[commit-bot: I haz the power, 2015-03-07 02:37:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 02:37:51]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[gone, 2015-03-07 02:41:10]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-03-07 02:42:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/989523003/60001

[commit-bot: I haz the power, 2015-03-07 03:46:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-07 03:47:39]

Patchset 4 (id:??) landed as
https://crrev.com/0e71dffca1885161e052d5c9fd3afed5c8aab5e1
Cr-Commit-Position: refs/heads/master@{#319551}