Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 989473004: Fix the kasko gyp var declaration. (Closed)

Created:
5 years, 9 months ago by erikwright (departed)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the kasko gyp var declaration. BUG=460512 Committed: https://crrev.com/98332b89c194936190d9609034a8c0f9a001c7e0 Cr-Commit-Position: refs/heads/master@{#319922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
erikwright (departed)
siggi: PTAL.
5 years, 9 months ago (2015-03-06 22:01:21 UTC) #2
Sigurður Ásgeirsson
lgtm
5 years, 9 months ago (2015-03-06 22:14:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989473004/1
5 years, 9 months ago (2015-03-09 14:37:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/48228)
5 years, 9 months ago (2015-03-09 14:54:31 UTC) #7
erikwright (departed)
scottmg: PTAL.
5 years, 9 months ago (2015-03-10 13:29:31 UTC) #9
scottmg
lgtm
5 years, 9 months ago (2015-03-10 16:22:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989473004/1
5 years, 9 months ago (2015-03-10 16:22:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 18:13:21 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 18:13:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98332b89c194936190d9609034a8c0f9a001c7e0
Cr-Commit-Position: refs/heads/master@{#319922}

Powered by Google App Engine
This is Rietveld 408576698