content/browser/web_contents/web_contents_impl.h - Issue 989473003: Reland of Refactor the loading tracking logic in WebContentsImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 989473003: Reland of Refactor the loading tracking logic in WebContentsImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 5cc17b8082475b77f0a65065e02c18f423747160..a6ef88b04e0727109f1ef1e6d06e50b3192fd008 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -1064,18 +1064,10 @@ class CONTENT_EXPORT WebContentsImpl

net::LoadStateWithParam load_state_;

base::string16 load_state_host_;

- // LoadingProgressMap maps FrameTreeNode IDs to a double representing that

- // frame's completion (from 0 to 1).

- typedef base::hash_map<int64, double> LoadingProgressMap;

- LoadingProgressMap loading_progresses_;

double loading_total_progress_;

base::TimeTicks loading_last_progress_update_;

- // Counter to track how many frames have sent start notifications but not

- // stop notifications.

- int loading_frames_in_progress_;

// Upload progress, for displaying in the status bar.

// Set to zero when there is no significant upload happening.

uint64 upload_size_;