Issue 989473002: Merge 190993 "Detach SpeechRecognitionController upon page detach."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 989473002: Merge 190993 "Detach SpeechRecognitionController upon page detach." (Closed)

Created:
5 years, 9 months ago by sof

Modified:
5 years, 9 months ago

Reviewers:
sof

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2311/

Project:
blink

Visibility:
Public.

Merge 190993 "Detach SpeechRecognitionController upon page detach." > Detach SpeechRecognitionController upon page detach. > > When a page is notified destroyed, it is no longer safe to access > the page's SpeechRecognitionController as its lifetime is that of > the page. > > R=haraken > BUG=455857 > > Review URL: https://codereview.chromium.org/960223002 TBR=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191416

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -15 lines)			Patch
A +	LayoutTests/fast/speech/scripted/speechrecognition-detached-no-crash.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/speech/scripted/speechrecognition-detached-no-crash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/modules/speech/SpeechRecognition.h	View	4 chunks	+19 lines, -2 lines	0 comments	Download
M	Source/modules/speech/SpeechRecognition.cpp	View	7 chunks	+24 lines, -15 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r191416.