Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 989463002: Read pixels in BGRA non-premul mode in few tests (Closed)

Created:
5 years, 9 months ago by Kimmo Kinnunen
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Read pixels in BGRA non-premul mode in few tests The tests assert on Sk_ColorGREEN, which is in BRGA non-premul. Read the pixels in same color format. Currently the tests pass on all platforms because GREEN is fully opaque and the component stays in the same place both on BGRA and RGBA. However, hypothetically somebody could copy-paste the assertion for further tests but use, say, RED. This creates latent error that is only visible on some platforms like mac. Committed: https://skia.googlesource.com/skia/+/a9d9a392380952006303d83c35a63a32dffd0b36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tests/ImageFilterTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/SkImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Kimmo Kinnunen
5 years, 9 months ago (2015-03-06 07:14:39 UTC) #2
Stephen White
LGTM
5 years, 9 months ago (2015-03-06 14:53:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989463002/1
5 years, 9 months ago (2015-03-06 15:10:29 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 15:16:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a9d9a392380952006303d83c35a63a32dffd0b36

Powered by Google App Engine
This is Rietveld 408576698