Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Issue 989363003: Don't allow quota requests without an infobar service (Closed)

Created:
5 years, 9 months ago by felt
Modified:
5 years, 9 months ago
Reviewers:
kinuko, Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow quota requests without an infobar service For legacy reasons, extensions can only request quota if there is an infobar service. In practice, this means that extension background pages are excluded. We should keep this same constraint to avoid changing callback behavior with permission bubbles. BUG= Committed: https://crrev.com/51f26d1f718456f09fe9f79eeb491da90e0c5ddf Cr-Commit-Position: refs/heads/master@{#319834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/chrome_quota_permission_context.cc View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
felt
kinuko, thestig, PTAL
5 years, 9 months ago (2015-03-10 01:55:43 UTC) #2
kinuko
lgtm
5 years, 9 months ago (2015-03-10 02:46:48 UTC) #3
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-10 03:04:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989363003/1
5 years, 9 months ago (2015-03-10 03:04:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 04:09:47 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 04:10:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51f26d1f718456f09fe9f79eeb491da90e0c5ddf
Cr-Commit-Position: refs/heads/master@{#319834}

Powered by Google App Engine
This is Rietveld 408576698