Issue 98933002: Experimental parser: crash fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98933002: Experimental parser: crash fix. (Closed)

Created:
7 years ago by marja

Modified:
7 years ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental parser: crash fix. PreParser doesn't own its scanner_, Parser does. This is confusing, since both inherit from ParserBase which has the scanner_ member variable (-> to be fixed later). TBR=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18186

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	src/parser.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/preparser.h	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r18186 (presubmit successful).

Expand Messages | Collapse Messages