Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 989283002: Fix off-by-one in SpdyFramer. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix off-by-one in SpdyFramer. Fix off-by-one in SpdyFramer::GetNumberRequiredContinuationFrames(). BUG=464748 Committed: https://crrev.com/3a80e999a73654103bce98e674932ee39e3db9dd Cr-Commit-Position: refs/heads/master@{#319684}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M net/spdy/spdy_framer.cc View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 9 months ago (2015-03-09 17:31:47 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/989283002/diff/1/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/989283002/diff/1/net/spdy/spdy_framer.cc#newcode2973 net/spdy/spdy_framer.cc:2973: return (overflow - 1) / payload_size + 1; ...
5 years, 9 months ago (2015-03-09 17:50:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989283002/1
5 years, 9 months ago (2015-03-09 17:53:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 18:07:47 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 18:08:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a80e999a73654103bce98e674932ee39e3db9dd
Cr-Commit-Position: refs/heads/master@{#319684}

Powered by Google App Engine
This is Rietveld 408576698