Use linked hash map for broken alternative service queue.

Use linked hash map for broken alternative service queue.

Use linked hash map for broken alternative service queue in
HttpServerPropertiesImpl.  This container has efficient lookup by key, allowing
us to use it as the definitive set of broken alternative services in an upcoming
CL.

Also rename broken_alternate_protocol_map_ to
recently_broken_alternative_services_ for consistency and because it makes more
sense.

BUG=392576
Committed: https://crrev.com/127681fccd8931673c36cdefea7aa3d62deea968
Cr-Commit-Position: refs/heads/master@{#319764}

[Bence, 2015-03-09 19:35:53]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2015-03-09 19:35:54]

Ryan, PTAL.  Thanks.

[Ryan Hamilton, 2015-03-09 19:48:27]

Looks good. One small comment.

https://codereview.chromium.org/989253005/diff/20001/net/http/http_server_pro...
File net/http/http_server_properties_impl.cc (right):

https://codereview.chromium.org/989253005/diff/20001/net/http/http_server_pro...
net/http/http_server_properties_impl.cc:329: // If alternative service is
already in expiration queue,
Since checking membership is constant time, how 'bout we just check to see if
it's already in the map and then just return, instead of adding and then
removing?

https://codereview.chromium.org/989253005/diff/20001/net/http/http_server_pro...
File net/http/http_server_properties_impl.h (right):

https://codereview.chromium.org/989253005/diff/20001/net/http/http_server_pro...
net/http/http_server_properties_impl.h:156: RecentlyBrokenAlternativeServices
recently_broken_alternative_services_;
Did you want to add a comment about membership in broken_ implying membership in
recently_broken_?

[Bence, 2015-03-09 21:24:36]

Ryan, PTAL.  I addressed both of your one small comment.

https://codereview.chromium.org/989253005/diff/20001/net/http/http_server_pro...
File net/http/http_server_properties_impl.cc (right):

https://codereview.chromium.org/989253005/diff/20001/net/http/http_server_pro...
net/http/http_server_properties_impl.cc:329: // If alternative service is
already in expiration queue,
On 2015/03/09 19:48:27, Ryan Hamilton wrote:
> Since checking membership is constant time, how 'bout we just check to see if
> it's already in the map and then just return, instead of adding and then
> removing?

Done.

https://codereview.chromium.org/989253005/diff/20001/net/http/http_server_pro...
File net/http/http_server_properties_impl.h (right):

https://codereview.chromium.org/989253005/diff/20001/net/http/http_server_pro...
net/http/http_server_properties_impl.h:156: RecentlyBrokenAlternativeServices
recently_broken_alternative_services_;
On 2015/03/09 19:48:27, Ryan Hamilton wrote:
> Did you want to add a comment about membership in broken_ implying membership
in
> recently_broken_?

Done.

[Ryan Hamilton, 2015-03-09 22:50:44]

lgtm

[Bence, 2015-03-09 23:03:28]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2015-03-09 23:05:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/989253005/40001

[commit-bot: I haz the power, 2015-03-09 23:24:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-09 23:25:23]

Patchset 3 (id:??) landed as
https://crrev.com/127681fccd8931673c36cdefea7aa3d62deea968
Cr-Commit-Position: refs/heads/master@{#319764}