Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 989253002: Revert of Roll WebRTC 8649:8651, Libjingle 8639:8651 (Closed)

Created:
5 years, 9 months ago by magjed_chromium
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll WebRTC 8649:8651, Libjingle 8639:8651 (patchset #1 id:1 of https://codereview.chromium.org/987033002/) Reason for revert: Broke compilation on Linux http://build.chromium.org/p/chromium/builders/Linux/builds/59264 with error message: AttributeError: 'Checker' object has no attribute 'run_js_check' Original issue's description: > Roll WebRTC 8649:8651, Libjingle 8639:8651 > > WebRTC 8649:8651 > Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/b4c07a0..61b3feb > > Libjingle 8639:8651 > Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/c9f4c13..4138f65 > > TBR=tommi > > Committed: https://crrev.com/f497d1fbcf1c0919ba260ed64ac18829b3acf7a0 > Cr-Commit-Position: refs/heads/master@{#319635} TBR=tommi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/62c6611787693f20f4201411d816d647f77f17d0 Cr-Commit-Position: refs/heads/master@{#319638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
magjed_chromium
Created Revert of Roll WebRTC 8649:8651, Libjingle 8639:8651
5 years, 9 months ago (2015-03-09 15:46:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989253002/1
5 years, 9 months ago (2015-03-09 15:46:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 15:47:34 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/62c6611787693f20f4201411d816d647f77f17d0 Cr-Commit-Position: refs/heads/master@{#319638}
5 years, 9 months ago (2015-03-09 15:48:17 UTC) #4
magjed_chromium
5 years, 9 months ago (2015-03-09 15:55:18 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/994603002/ by magjed@chromium.org.

The reason for reverting is: The compile error was not caused by the WebRTC
roll..

Powered by Google App Engine
This is Rietveld 408576698