Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5074)

Unified Diff: chrome/common/favicon/fallback_icon_url_parser.h

Issue 989183003: Revert of [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#". Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/fallback_icon_source.h ('k') | chrome/common/favicon/fallback_icon_url_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/favicon/fallback_icon_url_parser.h
diff --git a/chrome/common/favicon/fallback_icon_url_parser.h b/chrome/common/favicon/fallback_icon_url_parser.h
index 93d413908b833e4a4d3db77dc02751ab11cbc9e5..12a068f4e928e29b53fdab4ea657c7dc166cb44d 100644
--- a/chrome/common/favicon/fallback_icon_url_parser.h
+++ b/chrome/common/favicon/fallback_icon_url_parser.h
@@ -38,8 +38,8 @@
int *size,
favicon_base::FallbackIconStyle* style);
- // Helper to parse color string (e.g., "red", "#f00", "#aB0137"). On success,
- // returns true and writes te result to |*color|.
+ // Helper to parse color string (e.g., "red", "#f00", "#fF0000"). Returns true
+ // on success.
static bool ParseColor(const std::string& color_str, SkColor* color);
friend class FallbackIconUrlParserTest;
« no previous file with comments | « chrome/browser/ui/webui/fallback_icon_source.h ('k') | chrome/common/favicon/fallback_icon_url_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698