Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 989183003: Revert of [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#".

Created:
5 years, 9 months ago by Nico
Modified:
5 years, 9 months ago
Reviewers:
James Hawkins, huangs
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#". (patchset #4 id:60001 of https://codereview.chromium.org/988863002/) Reason for revert: Caused invalid reads on valgrind bots, see https://codereview.chromium.org/988863002/#msg28 Original issue's description: > [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#". > > Design: go/chrome-fallback-icons > > Fallback icon "explicit flow" URL used to have '#' in hex colors, e.g.: > > chrome://fallback-icon/,#01f,#123456,,/http://www.google.com > > Problem: "#" denotes fragment in URLs, so we get rid of it. This causes no ambiguity > with named color (e.g., "red") because no named color consists of letters a-f only. > Also adding "ARGB" hex color since this is supported in Skia color parsing. > > BUG=455063 > > Committed: https://crrev.com/8fa91aabefbe9784eca0c169bc2ad2dd92f5d887 > Cr-Commit-Position: refs/heads/master@{#319630} TBR=jhawkins@chromium.org,huangs@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -88 lines) Patch
M chrome/browser/ui/webui/fallback_icon_source.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/favicon/fallback_icon_url_parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/favicon/fallback_icon_url_parser.cc View 2 chunks +3 lines, -34 lines 0 comments Download
M chrome/common/favicon/fallback_icon_url_parser_unittest.cc View 11 chunks +48 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of [Fallback icons] Change "explicit flow" interface so color hex strings don't use ...
5 years, 9 months ago (2015-03-09 19:42:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989183003/1
5 years, 9 months ago (2015-03-09 19:43:05 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 19:44:16 UTC) #4
huangs
5 years, 9 months ago (2015-03-10 04:30:02 UTC) #6
On 2015/03/09 19:44:16, I haz the power (commit-bot) wrote:
> Failed to apply the patch.

Per discussion, the CL has already been reverted by bnc@.  We can close this CL.

Powered by Google App Engine
This is Rietveld 408576698