Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 989183002: Rollback V8 to version 4.3.25. (Closed)

Created:
5 years, 9 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : .25 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989183002/1
5 years, 9 months ago (2015-03-09 09:17:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989183002/1
5 years, 9 months ago (2015-03-09 09:18:26 UTC) #7
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 09:19:00 UTC) #9
Jakob Kummerow
Not LGTM. IIUC we want to go to 4.3.25.
5 years, 9 months ago (2015-03-09 09:21:13 UTC) #11
Michael Achenbach
Now?
5 years, 9 months ago (2015-03-09 09:28:21 UTC) #12
Michael Hablich
On 2015/03/09 09:28:21, Michael Achenbach wrote: > Now? Isn't that 4.3.23: https://chromium.googlesource.com/v8/v8.git/+/d6185423a1f5371c38b76f7321f558bfc7916a39 ?
5 years, 9 months ago (2015-03-09 09:29:53 UTC) #13
Michael Achenbach
how about now?
5 years, 9 months ago (2015-03-09 09:35:33 UTC) #14
Jakob Kummerow
lgtm
5 years, 9 months ago (2015-03-09 09:37:09 UTC) #15
Michael Hablich
On 2015/03/09 09:37:09, Jakob wrote: > lgtm lgtm
5 years, 9 months ago (2015-03-09 09:38:46 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/181ed5d75a0f62e253be317b7f3cd91955e5578a Cr-Commit-Position: refs/heads/master@{#319601}
5 years, 9 months ago (2015-03-09 09:39:11 UTC) #17
Michael Achenbach
5 years, 9 months ago (2015-03-09 09:39:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
181ed5d75a0f62e253be317b7f3cd91955e5578a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698