Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: src/debug.cc

Issue 989153003: remove phantom naming from the api (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/global-handles.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index c218f70d0d5a846ca468ab27971ceec4afb436ba..bdf8c3df3d9c88e9ba0c15f8fa2fcd10e2b1fe1c 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -608,9 +608,10 @@ DebugInfoListNode::DebugInfoListNode(DebugInfo* debug_info): next_(NULL) {
GlobalHandles* global_handles = debug_info->GetIsolate()->global_handles();
debug_info_ = Handle<DebugInfo>::cast(global_handles->Create(debug_info));
typedef PhantomCallbackData<void>::Callback Callback;
- GlobalHandles::MakePhantom(
- reinterpret_cast<Object**>(debug_info_.location()), this, 0,
- reinterpret_cast<Callback>(Debug::HandlePhantomDebugInfo));
+ GlobalHandles::MakeWeak(
+ reinterpret_cast<Object**>(debug_info_.location()), this,
+ reinterpret_cast<Callback>(Debug::HandlePhantomDebugInfo),
+ v8::WeakCallbackType::kParameter);
}
« no previous file with comments | « src/api.cc ('k') | src/global-handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698