Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 989153003: remove phantom naming from the api (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

remove phantom naming from the api since the old style weakness is slated for removal, we might as well reuse the name to limit confusion. additionally I simplified the callback type to a enum to either get internal field values or not this should be a non-breaking change with the exception of PhantomPersistentValueMap, which is unused. R=jochen@chromium.org, erikcorry@chromium.org BUG= Committed: https://crrev.com/60c1ad026d084b62fc963330af0b4802346eab7d Cr-Commit-Position: refs/heads/master@{#27084}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -175 lines) Patch
M include/v8.h View 1 2 8 chunks +74 lines, -53 lines 0 comments Download
M include/v8-util.h View 1 2 21 chunks +64 lines, -60 lines 0 comments Download
M src/api.cc View 1 2 3 1 chunk +17 lines, -9 lines 0 comments Download
M src/debug.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/global-handles.h View 1 3 chunks +6 lines, -7 lines 0 comments Download
M src/global-handles.cc View 1 5 chunks +34 lines, -37 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dcarney
ptal
5 years, 9 months ago (2015-03-09 13:53:42 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-09 13:55:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989153003/40001
5 years, 9 months ago (2015-03-09 13:57:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/3594)
5 years, 9 months ago (2015-03-09 14:11:33 UTC) #7
Erik Corry
lgtm
5 years, 9 months ago (2015-03-09 15:56:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989153003/80001
5 years, 9 months ago (2015-03-09 20:26:09 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-09 21:48:00 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 21:48:24 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/60c1ad026d084b62fc963330af0b4802346eab7d
Cr-Commit-Position: refs/heads/master@{#27084}

Powered by Google App Engine
This is Rietveld 408576698