chrome/browser/ui/webui/fallback_icon_source.h - Issue 989133003: Revert of [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/fallback_icon_source.h

Issue 989133003: Revert of [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/fallback_icon_source.h

diff --git a/chrome/browser/ui/webui/fallback_icon_source.h b/chrome/browser/ui/webui/fallback_icon_source.h

index ba4843e158bb902b602b7639ffac980c3171f965..086bbd0ffa492409f4d3c1e8ae4264bf727b08f5 100644

--- a/chrome/browser/ui/webui/fallback_icon_source.h

+++ b/chrome/browser/ui/webui/fallback_icon_source.h

@@ -20,11 +20,11 @@

// 'size'

// Positive integer to specify the fallback icon's size in pixels.

// 'bc'

-// Fallback icon's background color, as named CSS color, or RGB / ARGB /

-// RRGGBB / AARRGGBB hex formats (no leading "#").

+// Fallback icon's background color, as named CSS color, or #RGB / #RRGGBB /

+// #AARRGGBB hex formats.

// 'tc'

-// Fallback icon text color, as named CSS color, or RGB / ARGB / RRGGBB /

-// AARRGGBB hex formats (no leading "#").

+// Fallback icon text color, as named CSS color, or #RGB / #RRGGBB /

+// #AARRGGBB hex formats.

// 'fsr'

// Number in [0.0, 1.0] to specify the fallback icon's font size (pixels)

// as a ratio to the icon's size.

« no previous file with comments | « no previous file | chrome/common/favicon/fallback_icon_url_parser.h » ('j') | no next file with comments »