Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 989133002: [fdlibm] Inline coefficients for __kernel_sin and __kernel_cos. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
yanggou, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fdlibm] Inline coefficients for __kernel_sin and __kernel_cos. Loading the coefficients from a the constants typed array is currently blocking inlining MathSin and MathCos into TurboFan generated code, because there is no type feedback and hence TurboFan has to generate a LOAD_IC for every coefficient. R=yanggou@chromium.org BUG=v8:3952 LOG=n Committed: https://crrev.com/9bce5b347f4df7415354a412e39c65b5b91d7c52 Cr-Commit-Position: refs/heads/master@{#27057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M src/third_party/fdlibm/fdlibm.js View 3 chunks +19 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-09 06:15:16 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-09 06:19:17 UTC) #2
Yang
On 2015/03/09 06:19:17, Benedikt Meurer wrote: > PTAL Lgtm
5 years, 9 months ago (2015-03-09 06:26:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989133002/1
5 years, 9 months ago (2015-03-09 07:24:15 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 07:27:29 UTC) #7
Benedikt Meurer
Committed patchset #1 (id:1) manually as 9bce5b347f4df7415354a412e39c65b5b91d7c52 (presubmit successful).
5 years, 9 months ago (2015-03-09 07:30:16 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 07:30:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bce5b347f4df7415354a412e39c65b5b91d7c52
Cr-Commit-Position: refs/heads/master@{#27057}

Powered by Google App Engine
This is Rietveld 408576698