Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/compiler/ast-graph-builder.cc

Issue 989123003: [turbofan] Project exception value out of calls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/common-operator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/ast-graph-builder.h" 5 #include "src/compiler/ast-graph-builder.h"
6 6
7 #include "src/compiler.h" 7 #include "src/compiler.h"
8 #include "src/compiler/ast-loop-assignment-analyzer.h" 8 #include "src/compiler/ast-loop-assignment-analyzer.h"
9 #include "src/compiler/control-builders.h" 9 #include "src/compiler/control-builders.h"
10 #include "src/compiler/js-type-feedback.h" 10 #include "src/compiler/js-type-feedback.h"
(...skipping 3278 matching lines...) Expand 10 before | Expand all | Expand 10 after
3289 } 3289 }
3290 if (!environment()->IsMarkedAsUnreachable()) { 3290 if (!environment()->IsMarkedAsUnreachable()) {
3291 // Update the current control dependency for control-producing nodes. 3291 // Update the current control dependency for control-producing nodes.
3292 if (NodeProperties::IsControl(result)) { 3292 if (NodeProperties::IsControl(result)) {
3293 environment_->UpdateControlDependency(result); 3293 environment_->UpdateControlDependency(result);
3294 } 3294 }
3295 // Add implicit exception continuation for throwing nodes. 3295 // Add implicit exception continuation for throwing nodes.
3296 if (!result->op()->HasProperty(Operator::kNoThrow) && inside_try_scope) { 3296 if (!result->op()->HasProperty(Operator::kNoThrow) && inside_try_scope) {
3297 Node* on_exception = graph()->NewNode(common()->IfException(), result); 3297 Node* on_exception = graph()->NewNode(common()->IfException(), result);
3298 environment_->UpdateControlDependency(on_exception); 3298 environment_->UpdateControlDependency(on_exception);
3299 execution_control()->ThrowValue(result); 3299 execution_control()->ThrowValue(on_exception);
3300 } 3300 }
3301 // Add implicit success continuation for throwing nodes. 3301 // Add implicit success continuation for throwing nodes.
3302 if (!result->op()->HasProperty(Operator::kNoThrow)) { 3302 if (!result->op()->HasProperty(Operator::kNoThrow)) {
3303 Node* on_success = graph()->NewNode(common()->IfSuccess(), result); 3303 Node* on_success = graph()->NewNode(common()->IfSuccess(), result);
3304 environment_->UpdateControlDependency(on_success); 3304 environment_->UpdateControlDependency(on_success);
3305 } 3305 }
3306 } 3306 }
3307 } 3307 }
3308 3308
3309 return result; 3309 return result;
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
3520 // Phi does not exist yet, introduce one. 3520 // Phi does not exist yet, introduce one.
3521 value = NewPhi(inputs, value, control); 3521 value = NewPhi(inputs, value, control);
3522 value->ReplaceInput(inputs - 1, other); 3522 value->ReplaceInput(inputs - 1, other);
3523 } 3523 }
3524 return value; 3524 return value;
3525 } 3525 }
3526 3526
3527 } // namespace compiler 3527 } // namespace compiler
3528 } // namespace internal 3528 } // namespace internal
3529 } // namespace v8 3529 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/common-operator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698