Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 989083002: DM: show skipped and --blacklist notes only in verbose mode. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
scroggo, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: show skipped and --blacklist notes only in verbose mode. In non-verbose mode, these notes will spin away too fast to read anyway, unless they're so long they end up leaving junk on the terminal. NOTREECHECKS=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a6def476e98f92e6789dfa402283a7c44ee26cee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dm/DM.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein_C
5 years, 9 months ago (2015-03-08 16:16:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989083002/1
5 years, 9 months ago (2015-03-08 16:16:35 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-08 16:16:35 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-08 22:16:39 UTC) #7
scroggo
On 2015/03/08 22:16:39, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 9 months ago (2015-03-11 13:34:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989083002/1
5 years, 9 months ago (2015-03-11 14:14:03 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 14:19:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a6def476e98f92e6789dfa402283a7c44ee26cee

Powered by Google App Engine
This is Rietveld 408576698