Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 989023002: util/mach/exc_server_variants.cc: Remove unused typedefs (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M util/mach/exc_server_variants.cc View 2 chunks +0 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
I did a Crashpad build inside the Chromium tree. Chromium enables -Wunused-local-typedef, which caught this ...
5 years, 9 months ago (2015-03-07 19:04:16 UTC) #2
Robert Sesek
LGTM. I kind of like these for completeness, but integration is important.
5 years, 9 months ago (2015-03-08 03:32:30 UTC) #3
Mark Mentovai
https://codereview.chromium.org/989023002/diff/1/util/mach/exc_server_variants.cc File util/mach/exc_server_variants.cc (right): https://codereview.chromium.org/989023002/diff/1/util/mach/exc_server_variants.cc#newcode134 util/mach/exc_server_variants.cc:134: using ExceptionRaiseStateRequest = __Request__exception_raise_state_t; They’re still here, they’ve just ...
5 years, 9 months ago (2015-03-08 19:15:42 UTC) #4
Mark Mentovai
Committed patchset #1 (id:1) manually as 55861e88ce78498e500e668606a056881576280d (presubmit successful).
5 years, 9 months ago (2015-03-08 19:15:58 UTC) #5
Mark Mentovai
5 years, 9 months ago (2015-03-09 18:20:58 UTC) #6
Message was sent while issue was closed.
Note: Chromium doesn’t enable this warning explicitly, it’s a new warning in
clang that’s enabled at -Wall. Chrome uses a newer clang than the system clang,
so this didn’t appear until trying the in-Chromium build.

The warning is new in clang trunk r217298, and clang 3.6.

Powered by Google App Engine
This is Rietveld 408576698