Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: remoting/webapp/app_remoting/js/app_remoting.js

Issue 988963003: Add Application.Delegate.stop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer feedback. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/webapp/base/js/application.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/app_remoting/js/app_remoting.js
diff --git a/remoting/webapp/app_remoting/js/app_remoting.js b/remoting/webapp/app_remoting/js/app_remoting.js
index fb14f6d06827f24e5a6490fff0a577a5fba0002d..8ecb36c7df4396f958370cb805c5722f0d5f21bf 100644
--- a/remoting/webapp/app_remoting/js/app_remoting.js
+++ b/remoting/webapp/app_remoting/js/app_remoting.js
@@ -184,12 +184,7 @@ remoting.AppRemoting.prototype.start = function(connector, token) {
* @param {remoting.Error} error The failure reason.
*/
remoting.AppRemoting.prototype.signInFailed = function(error) {
- if (error == remoting.Error.CANCELLED) {
- chrome.app.window.current().close();
- remoting.LoadingWindow.close();
- } else {
- this.handleError(error);
- }
+ this.handleError(error);
};
/**
@@ -343,3 +338,10 @@ remoting.AppRemoting.prototype.handleError = function(errorTag) {
chrome.i18n.getMessage(/*i18n-content*/'CONNECTION_FAILED'),
chrome.i18n.getMessage(/** @type {string} */ (errorTag)));
};
+
+/**
+ * Close the loading window before exiting.
+ */
+remoting.AppRemoting.prototype.handleExit = function() {
+ remoting.LoadingWindow.close();
+};
« no previous file with comments | « no previous file | remoting/webapp/base/js/application.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698