Add Application.Delegate.stop.

remoting/webapp/app_remoting/js/app_remoting.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * This class implements the functionality that is specific to application
  * remoting ("AppRemoting" or AR).
  */
 
@@ skipping 166 matching lines @@
   });
 };
 
 /**
  * Report an authentication error to the user. This is called in lieu of start()
  * if the user cannot be authenticated or if they decline the app permissions.
  *
  * @param {remoting.Error} error The failure reason.
  */
 remoting.AppRemoting.prototype.signInFailed = function(error) {
-  if (error == remoting.Error.CANCELLED) {
-    chrome.app.window.current().close();
-    remoting.LoadingWindow.close();
-  } else {
-    this.handleError(error);
-  }
+  this.handleError(error);
 };
 
 /**
+ * Close the loading window before exiting.
+ */
+remoting.AppRemoting.prototype.stop = function() {

[kelvinp, 2015/03/09 17:48:49]

Would close or onShutdown be a better name, since it is supposed to call before
exit?

[Jamie, 2015/03/09 17:58:11]

I've gone with handleExit to match the other handle* methods.

+  remoting.LoadingWindow.close();
+};
+
+/**
  * @return {string} Application product name to be used in UI.
  */
 remoting.AppRemoting.prototype.getApplicationName = function() {
   var manifest = chrome.runtime.getManifest();
   return manifest.name;
 };
 
 /** @return {string} */
 remoting.AppRemoting.prototype.runApplicationUrl = function() {
   return remoting.settings.APP_REMOTING_API_BASE_URL + '/applications/' +
@@ skipping 130 matching lines @@
  * @param {remoting.Error} errorTag The error to be localized and displayed.
  * @return {void} Nothing.
  */
 remoting.AppRemoting.prototype.handleError = function(errorTag) {
   console.error('Connection failed: ' + errorTag);
   remoting.LoadingWindow.close();
   remoting.MessageWindow.showErrorMessage(
       chrome.i18n.getMessage(/*i18n-content*/'CONNECTION_FAILED'),
       chrome.i18n.getMessage(/** @type {string} */ (errorTag)));
 };