Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 988963003: Add Application.Delegate.stop. (Closed)

Created:
5 years, 9 months ago by Jamie
Modified:
5 years, 9 months ago
Reviewers:
garykac, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Application.Delegate.stop. This provides a central location for application-specific cleanup code and also allows the "no error message on cancel" logic to be made application-agnostic. Committed: https://crrev.com/32af42a8103c97258a0eca1ec7255e7a849b82aa Cr-Commit-Position: refs/heads/master@{#319705}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Reviewer feedback. #

Total comments: 2

Patch Set 3 : Reviewer feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
M remoting/webapp/app_remoting/js/app_remoting.js View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M remoting/webapp/base/js/application.js View 1 2 3 chunks +30 lines, -3 lines 0 comments Download
M remoting/webapp/crd/js/app_launcher.js View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/crd/js/desktop_remoting.js View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M remoting/webapp/crd/js/window_frame.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Jamie
ptal https://codereview.chromium.org/988963003/diff/1/remoting/webapp/crd/js/app_launcher.js File remoting/webapp/crd/js/app_launcher.js (right): https://codereview.chromium.org/988963003/diff/1/remoting/webapp/crd/js/app_launcher.js#newcode154 remoting/webapp/crd/js/app_launcher.js:154: appWindow.close(); @kelvinp: I feel that this should just ...
5 years, 9 months ago (2015-03-07 02:12:54 UTC) #2
garykac
lgtm https://codereview.chromium.org/988963003/diff/1/remoting/webapp/base/js/application.js File remoting/webapp/base/js/application.js (right): https://codereview.chromium.org/988963003/diff/1/remoting/webapp/base/js/application.js#newcode108 remoting/webapp/base/js/application.js:108: catch(remoting.Error.handler( This indentation looks wrong.
5 years, 9 months ago (2015-03-07 02:16:01 UTC) #3
Jamie
FYI https://codereview.chromium.org/988963003/diff/1/remoting/webapp/base/js/application.js File remoting/webapp/base/js/application.js (right): https://codereview.chromium.org/988963003/diff/1/remoting/webapp/base/js/application.js#newcode108 remoting/webapp/base/js/application.js:108: catch(remoting.Error.handler( On 2015/03/07 02:16:01, garykac wrote: > This ...
5 years, 9 months ago (2015-03-09 17:41:16 UTC) #4
kelvinp
https://codereview.chromium.org/988963003/diff/1/remoting/webapp/crd/js/app_launcher.js File remoting/webapp/crd/js/app_launcher.js (right): https://codereview.chromium.org/988963003/diff/1/remoting/webapp/crd/js/app_launcher.js#newcode154 remoting/webapp/crd/js/app_launcher.js:154: appWindow.close(); On 2015/03/07 02:12:54, Jamie wrote: > @kelvinp: I ...
5 years, 9 months ago (2015-03-09 17:48:49 UTC) #5
kelvinp
lgtm
5 years, 9 months ago (2015-03-09 17:54:48 UTC) #6
Jamie
FYI https://codereview.chromium.org/988963003/diff/20001/remoting/webapp/app_remoting/js/app_remoting.js File remoting/webapp/app_remoting/js/app_remoting.js (right): https://codereview.chromium.org/988963003/diff/20001/remoting/webapp/app_remoting/js/app_remoting.js#newcode193 remoting/webapp/app_remoting/js/app_remoting.js:193: remoting.AppRemoting.prototype.stop = function() { On 2015/03/09 17:48:49, kelvinp ...
5 years, 9 months ago (2015-03-09 17:58:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988963003/40001
5 years, 9 months ago (2015-03-09 17:58:54 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 19:18:23 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 19:19:14 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/32af42a8103c97258a0eca1ec7255e7a849b82aa
Cr-Commit-Position: refs/heads/master@{#319705}

Powered by Google App Engine
This is Rietveld 408576698