Add Application.Delegate.stop.

Add Application.Delegate.stop.

This provides a central location for application-specific cleanup code and also
allows the "no error message on cancel" logic to be made application-agnostic.

Committed: https://crrev.com/32af42a8103c97258a0eca1ec7255e7a849b82aa
Cr-Commit-Position: refs/heads/master@{#319705}

[Jamie, 2015-03-07 02:12:53]

jamiewalch@chromium.org changed reviewers:
+ garykac@chromium.org, kelvinp@chromium.org

[Jamie, 2015-03-07 02:12:54]

ptal

https://codereview.chromium.org/988963003/diff/1/remoting/webapp/crd/js/app_l...
File remoting/webapp/crd/js/app_launcher.js (right):

https://codereview.chromium.org/988963003/diff/1/remoting/webapp/crd/js/app_l...
remoting/webapp/crd/js/app_launcher.js:154: appWindow.close();
@kelvinp: I feel that this should just call application.exit, but I don't
understand this class well enough to know how to achieve that.

[garykac, 2015-03-07 02:16:01]

lgtm

https://codereview.chromium.org/988963003/diff/1/remoting/webapp/base/js/appl...
File remoting/webapp/base/js/application.js (right):

https://codereview.chromium.org/988963003/diff/1/remoting/webapp/base/js/appl...
remoting/webapp/base/js/application.js:108: catch(remoting.Error.handler(
This indentation looks wrong.

[Jamie, 2015-03-09 17:41:16]

FYI

https://codereview.chromium.org/988963003/diff/1/remoting/webapp/base/js/appl...
File remoting/webapp/base/js/application.js (right):

https://codereview.chromium.org/988963003/diff/1/remoting/webapp/base/js/appl...
remoting/webapp/base/js/application.js:108: catch(remoting.Error.handler(
On 2015/03/07 02:16:01, garykac wrote:
> This indentation looks wrong.

Done.

[kelvinp, 2015-03-09 17:48:49]

https://codereview.chromium.org/988963003/diff/1/remoting/webapp/crd/js/app_l...
File remoting/webapp/crd/js/app_launcher.js (right):

https://codereview.chromium.org/988963003/diff/1/remoting/webapp/crd/js/app_l...
remoting/webapp/crd/js/app_launcher.js:154: appWindow.close();
On 2015/03/07 02:12:54, Jamie wrote:
> @kelvinp: I feel that this should just call application.exit, but I don't
> understand this class well enough to know how to achieve that.

This class is currently run at the background page.  So it would need to post a
message back to the main.html for exit.

Close() is only used in HRD before so this is now not used.  I think for the
purpose of this CL, we can leave this code unchanged.

https://codereview.chromium.org/988963003/diff/20001/remoting/webapp/app_remo...
File remoting/webapp/app_remoting/js/app_remoting.js (right):

https://codereview.chromium.org/988963003/diff/20001/remoting/webapp/app_remo...
remoting/webapp/app_remoting/js/app_remoting.js:193:
remoting.AppRemoting.prototype.stop = function() {
Would close or onShutdown be a better name, since it is supposed to call before
exit?

[kelvinp, 2015-03-09 17:54:48]

lgtm

[Jamie, 2015-03-09 17:58:11]

FYI

https://codereview.chromium.org/988963003/diff/20001/remoting/webapp/app_remo...
File remoting/webapp/app_remoting/js/app_remoting.js (right):

https://codereview.chromium.org/988963003/diff/20001/remoting/webapp/app_remo...
remoting/webapp/app_remoting/js/app_remoting.js:193:
remoting.AppRemoting.prototype.stop = function() {
On 2015/03/09 17:48:49, kelvinp wrote:
> Would close or onShutdown be a better name, since it is supposed to call
before
> exit?

I've gone with handleExit to match the other handle* methods.

[Jamie, 2015-03-09 17:58:17]

The CQ bit was checked by jamiewalch@chromium.org

[Jamie, 2015-03-09 17:58:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
garykac@chromium.org, kelvinp@chromium.org
Link to the patchset: https://codereview.chromium.org/988963003/#ps40001 (title:
"Reviewer feedback.")

[commit-bot: I haz the power, 2015-03-09 17:58:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/988963003/40001

[commit-bot: I haz the power, 2015-03-09 19:18:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-09 19:19:14]

Patchset 3 (id:??) landed as
https://crrev.com/32af42a8103c97258a0eca1ec7255e7a849b82aa
Cr-Commit-Position: refs/heads/master@{#319705}