Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 988953003: OOPIF: Fix cross-process navigations in new windows. (Closed)

Created:
5 years, 9 months ago by Charlie Reis
Modified:
5 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, alexmos, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OOPIF: Fix cross-process navigations in new windows. We were putting the wrong FrameTreeNode ID on the OpenURLParams when a navigation was destined for a different WebContents. BUG=464944 TEST=Shift click a link to https://chrome.google.com/webstore in --site-per-process mode. Committed: https://crrev.com/b1a8a668fe3478ddb399eef33728914fe01a8a43 Cr-Commit-Position: refs/heads/master@{#319690}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/browser/frame_host/navigator_impl.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Charlie Reis
Nasko, can you take a look? This should get the try bot to go green.
5 years, 9 months ago (2015-03-07 00:47:35 UTC) #2
nasko
LGTM https://codereview.chromium.org/988953003/diff/1/content/browser/frame_host/navigator_impl.cc File content/browser/frame_host/navigator_impl.cc (right): https://codereview.chromium.org/988953003/diff/1/content/browser/frame_host/navigator_impl.cc#newcode623 content/browser/frame_host/navigator_impl.cc:623: // Send the navigation to the current FrameTreeNode ...
5 years, 9 months ago (2015-03-07 00:55:15 UTC) #3
Charlie Reis
Thanks. Glad to see the linux_site_isolation try bot went green! CQ'ing. https://codereview.chromium.org/988953003/diff/1/content/browser/frame_host/navigator_impl.cc File content/browser/frame_host/navigator_impl.cc (right): ...
5 years, 9 months ago (2015-03-07 03:23:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988953003/20001
5 years, 9 months ago (2015-03-07 03:24:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 05:25:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988953003/20001
5 years, 9 months ago (2015-03-09 16:44:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 18:22:02 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 18:23:00 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1a8a668fe3478ddb399eef33728914fe01a8a43
Cr-Commit-Position: refs/heads/master@{#319690}

Powered by Google App Engine
This is Rietveld 408576698