Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 98893003: Remove TreatNullAs=NullString for HTMLMarqueeElement (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLMarqueeElement http://whatwg.org/html#htmlmarqueeelement Very few of the tests pass in any other browser, with little agreement between them. There might be spec or implementation work to do here, but this change is likely safe regardless. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163035

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
7 years ago (2013-12-02 14:27:22 UTC) #1
arv (Not doing code reviews)
LGTM
7 years ago (2013-12-02 15:00:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/98893003/1
7 years ago (2013-12-02 15:09:18 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/dom/element-attribute-js-null-expected.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-02 16:45:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/98893003/10001
7 years ago (2013-12-02 20:22:24 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-02 22:47:02 UTC) #6
Message was sent while issue was closed.
Change committed as 163035

Powered by Google App Engine
This is Rietveld 408576698