Source/core/paint/InlineTextBoxPainter.cpp - Issue 988903002: [S.P.] Fix cull rects for InlineTextBox to account for vertical text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/InlineTextBoxPainter.cpp

Issue 988903002: [S.P.] Fix cull rects for InlineTextBox to account for vertical text. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/paint/InlineTextBoxPainter.cpp

diff --git a/Source/core/paint/InlineTextBoxPainter.cpp b/Source/core/paint/InlineTextBoxPainter.cpp

index c32e394ed41d99f3ad4410fa7f59da9402f47ba9..ad57dd1843088bdcde14d72ab8238fdcfadcc432 100644

--- a/Source/core/paint/InlineTextBoxPainter.cpp

+++ b/Source/core/paint/InlineTextBoxPainter.cpp

@@ -75,7 +75,7 @@ void InlineTextBoxPainter::paint(const PaintInfo& paintInfo, const LayoutPoint&

// within a DrawingRecorder.

OwnPtr<DrawingRecorder> drawingRecorder;

if (RuntimeEnabledFeatures::slimmingPaintEnabled() && paintInfo.phase != PaintPhaseTextClip) {

- LayoutRect paintRect = logicalVisualOverflow;

+ LayoutRect paintRect(m_inlineTextBox.logicalRectToPhysicalRect(logicalVisualOverflow));

paintRect.moveBy(adjustedPaintOffset);

drawingRecorder = adoptPtr(new DrawingRecorder(paintInfo.context, m_inlineTextBox.displayItemClient(), DisplayItem::paintPhaseToDrawingType(paintInfo.phase), paintRect));

if (drawingRecorder->canUseCachedDrawing())

« no previous file with comments | « Source/core/layout/line/InlineBox.cpp ('k') | no next file » | no next file with comments »