Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: src/libplatform/default-platform.cc

Issue 988893003: Implement tracing interface for v8 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove v8-tracing in favor of v8-platform, make passing Isolate* explicit, still WIP Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/libplatform/default-platform.cc
diff --git a/src/libplatform/default-platform.cc b/src/libplatform/default-platform.cc
index ddceab54572d12f3a4f5ce6db9ced6675e8f6ed4..c6e9e3a88807a1a312db5fcb05f277fae752bdc5 100644
--- a/src/libplatform/default-platform.cc
+++ b/src/libplatform/default-platform.cc
@@ -168,4 +168,26 @@ double DefaultPlatform::MonotonicallyIncreasingTime() {
return base::TimeTicks::HighResolutionNow().ToInternalValue() /
static_cast<double>(base::Time::kMicrosecondsPerSecond);
}
+
+uint64_t DefaultPlatform::AddTraceEvent(
+ char phase, const uint8_t* categoryEnabledFlag, const char* name,
+ uint64_t id, uint64_t context_id, uint64_t bind_id, int numArgs,
+ const char** argNames, const uint8_t* argTypes, const uint64_t* argValues,
+ unsigned int flags) {
+ return 0;
+}
+
+void DefaultPlatform::UpdateTraceEventDuration(
+ const uint8_t* categoryEnabledFlag, const char* name, uint64_t handle) {}
+
+const uint8_t* DefaultPlatform::GetCategoryGroupEnabled(const char* name) {
+ static uint8_t no = 0;
+ return &no;
+}
+
+const char* DefaultPlatform::GetCategoryGroupName(
+ const uint8_t* categoryEnabledFlag) {
+ static const char* dummy = "dummy";
noordhuis 2015/10/07 18:31:54 `static const char[] dummy = ...`?
fmeawad 2015/11/19 02:00:47 Done.
+ return dummy;
+}
} } // namespace v8::platform

Powered by Google App Engine
This is Rietveld 408576698