Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issue 988883003: Widen the keyboard detection logic on Windows 8 touch devices and detect slate mode to force OSK on. (Closed)

Created:
5 years, 9 months ago by ananta
Modified:
5 years, 9 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Widen the keyboard detection logic on Windows 8 touch devices and detect slate mode to force OSK on. Changes in this patch as below:- 1. We now check if the device is docked and avoid displaying the OSK in this case. 2. Check the auto rotation state of the device via the GetAutoRotationState API. If auto rotation is disabled or not supported we can safely assume that a keyboard is present on the system. 3. Allow ACPI\* device names in the keyboard device name matching code. 4. Detect if the device is in slate mode, i.e. the keyboard is flipped. We need to display the OSK in this case. BUG=335735 Committed: https://crrev.com/6c49583dfa8912e769d313ea8bae19a23bc09879 Cr-Commit-Position: refs/heads/master@{#319826}

Patch Set 1 #

Patch Set 2 : Check autorotation state #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
M base/win/win_util.cc View 1 2 chunks +50 lines, -4 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
ananta
5 years, 9 months ago (2015-03-07 02:16:41 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/988883003/diff/20001/base/win/win_util.cc File base/win/win_util.cc (right): https://codereview.chromium.org/988883003/diff/20001/base/win/win_util.cc#newcode114 base/win/win_util.cc:114: POWER_PLATFORM_ROLE role = PowerDeterminePlatformRole(); is PowerDeterminePlatformRole() delay loaded? ...
5 years, 9 months ago (2015-03-09 20:30:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988883003/20001
5 years, 9 months ago (2015-03-10 00:58:42 UTC) #5
ananta
https://codereview.chromium.org/988883003/diff/20001/base/win/win_util.cc File base/win/win_util.cc (right): https://codereview.chromium.org/988883003/diff/20001/base/win/win_util.cc#newcode114 base/win/win_util.cc:114: POWER_PLATFORM_ROLE role = PowerDeterminePlatformRole(); On 2015/03/09 20:30:05, cpu wrote: ...
5 years, 9 months ago (2015-03-10 02:00:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 02:43:35 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 02:44:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c49583dfa8912e769d313ea8bae19a23bc09879
Cr-Commit-Position: refs/heads/master@{#319826}

Powered by Google App Engine
This is Rietveld 408576698