Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 988853002: Moved the javascript files for each respective guest_view type into subdirectories of guest_view/ . (Closed)

Created:
5 years, 9 months ago by paulmeyer
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved the javascript files for each respective guest_view type into subdirectories of guest_view/ . BUG=464803 TBR=rockot@chromium.org Committed: https://crrev.com/968f8ef946df12f19e636a840e37d6808d5b1ab8 Cr-Commit-Position: refs/heads/master@{#319516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1623 lines) Patch
M extensions/renderer/resources/extensions_renderer_resources.grd View 3 chunks +23 lines, -23 lines 0 comments Download
D extensions/renderer/resources/guest_view/app_view.js View 1 chunk +0 lines, -81 lines 0 comments Download
A + extensions/renderer/resources/guest_view/app_view/app_view.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/app_view/app_view_deny.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D extensions/renderer/resources/guest_view/app_view_deny.js View 1 chunk +0 lines, -39 lines 0 comments Download
D extensions/renderer/resources/guest_view/surface_view.js View 1 chunk +0 lines, -52 lines 0 comments Download
A + extensions/renderer/resources/guest_view/surface_view/surface_view.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view.js View 1 chunk +0 lines, -234 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view/web_view.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view/web_view_api_methods.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view/web_view_attributes.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view/web_view_constants.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view/web_view_deny.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view/web_view_events.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view/web_view_experimental.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view/web_view_internal.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/guest_view/web_view/web_view_request_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view_action_requests.js View 1 chunk +0 lines, -260 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view_api_methods.js View 1 chunk +0 lines, -160 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view_attributes.js View 1 chunk +0 lines, -343 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view_constants.js View 1 chunk +0 lines, -43 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view_deny.js View 1 chunk +0 lines, -38 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view_events.js View 1 chunk +0 lines, -280 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view_experimental.js View 1 chunk +0 lines, -22 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view_internal.js View 1 chunk +0 lines, -6 lines 0 comments Download
D extensions/renderer/resources/guest_view/web_view_request_custom_bindings.js View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paulmeyer
+fsamuel@
5 years, 9 months ago (2015-03-06 20:36:53 UTC) #2
Fady Samuel
lgtm
5 years, 9 months ago (2015-03-06 20:38:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988853002/1
5 years, 9 months ago (2015-03-06 20:40:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 22:25:31 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 22:26:09 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/968f8ef946df12f19e636a840e37d6808d5b1ab8
Cr-Commit-Position: refs/heads/master@{#319516}

Powered by Google App Engine
This is Rietveld 408576698