Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: chrome/browser/resources/settings/downloads_page/downloads_page.js

Issue 988783002: Add an initial implementation of the downloads MD settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to jeremy's comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/downloads_page/downloads_page.js
diff --git a/chrome/browser/resources/settings/a11y_page/a11y_page.js b/chrome/browser/resources/settings/downloads_page/downloads_page.js
similarity index 54%
copy from chrome/browser/resources/settings/a11y_page/a11y_page.js
copy to chrome/browser/resources/settings/downloads_page/downloads_page.js
index 872d6a41f9d9587f294705da7da0600079af465c..e86a04c09872d4a7587e620f51404bed217e20fc 100644
--- a/chrome/browser/resources/settings/a11y_page/a11y_page.js
+++ b/chrome/browser/resources/settings/downloads_page/downloads_page.js
@@ -4,20 +4,20 @@
/**
* @fileoverview
- * 'cr-settings-a11y-page' is the settings page containing accessibility
+ * 'cr-settings-downloads-page' is the settings page containing all downloads
* settings.
*
* Example:
*
* <core-animated-pages>
- * <cr-settings-a11y-page></cr-settings-a11y-page>
+ * <cr-settings-downloads-page></cr-settings-downloads-page>
* ... other pages ...
* </core-animated-pages>
*
* @group Chrome Settings Elements
- * @element cr-settings-a11y-page
+ * @element cr-settings-downloads-page
*/
-Polymer('cr-settings-a11y-page', {
+Polymer('cr-settings-downloads-page', {
publish: {
/**
* Preferences state.
@@ -26,6 +26,12 @@ Polymer('cr-settings-a11y-page', {
* @type CrSettingsPrefsElement
* @default null
*/
- prefs: null,
+ prefs: null
+ },
+
+ selectDownloadLocation: function() {
+ // TODO(orenb): Communicate with the C++ to actually display a folder
+ // picker.
+ this.$.downloadsPath.value = '/Downloads';
Jeremy Klein 2015/03/06 20:01:17 I guess you might as well also set the prefs value
Oren Blasberg 2015/03/06 21:40:25 Done.
},
});

Powered by Google App Engine
This is Rietveld 408576698