chrome/browser/resources/settings/downloads_page/downloads_page.js - Issue 988783002: Add an initial implementation of the downloads MD settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/downloads_page/downloads_page.js

Issue 988783002: Add an initial implementation of the downloads MD settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to Michael's comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/downloads_page/downloads_page.html ('k') | chrome/browser/resources/settings/prefs/prefs.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/downloads_page/downloads_page.js

diff --git a/chrome/browser/resources/settings/a11y_page/a11y_page.js b/chrome/browser/resources/settings/downloads_page/downloads_page.js

similarity index 56%

copy from chrome/browser/resources/settings/a11y_page/a11y_page.js

copy to chrome/browser/resources/settings/downloads_page/downloads_page.js

index 0af1e678887ab875715b2f240de20f4e02f4fe01..6ac7176a4ce1af26733b69f7a3fe7590039bb2a3 100644

--- a/chrome/browser/resources/settings/a11y_page/a11y_page.js

+++ b/chrome/browser/resources/settings/downloads_page/downloads_page.js

@@ -4,20 +4,20 @@

/**

* @fileoverview

- * 'cr-settings-a11y-page' is the settings page containing accessibility

+ * 'cr-settings-downloads-page' is the settings page containing downloads

* settings.

* Example:

* <core-animated-pages>

- * <cr-settings-a11y-page></cr-settings-a11y-page>

+ * <cr-settings-downloads-page></cr-settings-downloads-page>

* ... other pages ...

* </core-animated-pages>

* @group Chrome Settings Elements

- * @element cr-settings-a11y-page

+ * @element cr-settings-downloads-page

-Polymer('cr-settings-a11y-page', {

+Polymer('cr-settings-downloads-page', {

publish: {

/**

* Preferences state.

@@ -28,4 +28,10 @@ Polymer('cr-settings-a11y-page', {

prefs: null,

+ selectDownloadLocation: function() {

+ // TODO(orenb): Communicate with the C++ to actually display a folder

+ // picker.

+ this.$.downloadsPath.value = '/Downloads';

+ },

});