chrome/browser/resources/settings/prefs/prefs.js - Issue 988783002: Add an initial implementation of the downloads MD settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/prefs/prefs.js

Issue 988783002: Add an initial implementation of the downloads MD settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add the missing demo.js I accidentally omitted in previous patch. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/downloads_page/downloads_page.js ('K') | « chrome/browser/resources/settings/downloads_page/downloads_page.js ('k') | chrome/browser/resources/settings/prefs/prefs_types.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/prefs/prefs.js

diff --git a/chrome/browser/resources/settings/prefs/prefs.js b/chrome/browser/resources/settings/prefs/prefs.js

index a50dd7f9852e8b54892725b0cae13f7d54a66405..3bdcca631f8b4d80cd948a02f683e9dbe69c603a 100644

--- a/chrome/browser/resources/settings/prefs/prefs.js

+++ b/chrome/browser/resources/settings/prefs/prefs.js

@@ -34,6 +34,7 @@ Polymer('cr-settings-prefs', {

this.settings = {};

this.initializeA11y_();

+ this.initializeDownloads_();

var observer = new ObjectObserver(this.settings);

observer.open(this.propertyChangeCallback_.bind(this, 'settings'));

@@ -76,6 +77,17 @@ Polymer('cr-settings-prefs', {

/**

+ * Initializes some defaults for the downloads settings.

+ * @private

+ */

+ initializeDownloads_: function() {

+ this.settings.downloads = {

michaelpg 2015/03/08 05:37:36 If we're matching pref_names.cc, this would be "do

Oren Blasberg 2015/03/09 21:05:05 Done.

+ downloadLocation: '',

michaelpg 2015/03/08 05:37:36 If we're matching pref_names.cc, this would be def

Oren Blasberg 2015/03/09 21:05:05 Done.

+ promptForDownload: false,

+ };

+ },

+ /**

* @param {string} propertyPath The path before the property names.

* @param {!Array<string>} added An array of keys which were added.

* @param {!Array<string>} removed An array of keys which were removed.