chrome/browser/resources/settings/downloads_page/downloads_page.html - Issue 988783002: Add an initial implementation of the downloads MD settings page.

Side by Side Diff: chrome/browser/resources/settings/downloads_page/downloads_page.html

Issue 988783002: Add an initial implementation of the downloads MD settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add the missing demo.js I accidentally omitted in previous patch. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/downloads_page/downloads_page.css ('K') | « chrome/browser/resources/settings/downloads_page/downloads_page.css ('k') | chrome/browser/resources/settings/downloads_page/downloads_page.js » ('j') | chrome/browser/resources/settings/downloads_page/downloads_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/core-label/core-label.html">

	3 <link rel="import" href="chrome://resources/polymer/paper-input/paper-input.html ">

	4 <link rel="import" href="chrome://resources/cr_elements/cr_button/cr_button.

	5 html">

	6 <link rel="import" href="chrome://resources/cr_elements/cr_checkbox/cr_checkbox.

	7 html">

	8 <link rel="import" href="chrome://resources/cr_elements/cr_input/cr_input.html">

	9

	10 <polymer-element name="cr-settings-downloads-page" layout vertical>

	11 <template>

	12 <link rel="stylesheet" href="downloads_page.css">

	13 <div horizontal layout center>

	14 <core-label horizontal layout center>

	15 <span class="location-label">Download location:</span>

	16 <cr-input id="downloadsPath" floatingLabel="false" size="36"
	michaelpg 2015/03/08 05:37:36 Does size="36" work? I don't see it as an attribut Does size="36" work? I don't see it as an attribute on cr-input (or the <input> within core-input) michaelpg 2015/03/08 05:37:36 FYI, per the Chrome style guide, IDs use dash-form FYI, per the Chrome style guide, IDs use dash-form, not camelCase: http://www.chromium.org/developers/web-development-style-guide But Polymer's this.$ hash is so convenient and would be uglier if IDs had dashes: this.$.downloadsPath this.$['downloads-path'] So I would say as long as we're consistent within elements, let's ignore this rule. any objections? The rationale for id-hyphens in the Google HTML style guide is "to improve understanding and scannability" which I think camelCase also does just fine. Kyle Horimoto 2015/03/09 20:16:21 Probably good to bring this up on the list. Show quoted text On 2015/03/08 05:37:36, michaelpg wrote: > FYI, per the Chrome style guide, IDs use dash-form, not camelCase: > http://www.chromium.org/developers/web-development-style-guide > > But Polymer's this.$ hash is so convenient and would be uglier if IDs had > dashes: > this.$.downloadsPath > this.$['downloads-path'] > > So I would say as long as we're consistent within elements, let's ignore this > rule. any objections? > > The rationale for id-hyphens in the Google HTML style guide is "to improve > understanding and scannability" which I think camelCase also does just fine. Probably good to bring this up on the list. Oren Blasberg 2015/03/09 21:05:05 OK, I'll keep it camel case for now. Removed size= Show quoted text On 2015/03/09 20:16:21, Kyle Horimoto wrote: > On 2015/03/08 05:37:36, michaelpg wrote: > > FYI, per the Chrome style guide, IDs use dash-form, not camelCase: > > http://www.chromium.org/developers/web-development-style-guide > > > > But Polymer's this.$ hash is so convenient and would be uglier if IDs had > > dashes: > > this.$.downloadsPath > > this.$['downloads-path'] > > > > So I would say as long as we're consistent within elements, let's ignore this > > rule. any objections? > > > > The rationale for id-hyphens in the Google HTML style guide is "to improve > > understanding and scannability" which I think camelCase also does just fine. > > Probably good to bring this up on the list. OK, I'll keep it camel case for now. Removed size=36.
	17 readonly for>

	18 </cr-input>

	19 </core-label>

	20 <cr-button id="changeDownloadsPath"

	21 on-click="{{selectDownloadLocation}}">Change</cr-button>

	22 </div>

	23 <core-label horizontal layout>

	24 <cr-checkbox checked="{{prefs.settings.downloads.promptForDownload}}" for>

	25 </cr-checkbox>

	26 <span>Ask where to save each file before downloading</span>

	27 </core-label>

	28 </template>

	29 <script src="downloads_page.js"></script>

	30 </polymer-element>

OLD	NEW